Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integration test for swap #586

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

zarboq
Copy link
Collaborator

@zarboq zarboq commented Nov 10, 2023

Pull Request type

  • Feature
  • Testing

What is the current behavior?

There is no integration test for swap.

What is the new behavior?

Integration test for swap & fixing swap workflow mainly, still have to fix oracle account signature check. Merging bc lot of fixes have been made that will be needful for other tests. Will continue in another PR.

@zarboq zarboq marked this pull request as ready for review November 20, 2023 09:39
@zarboq zarboq requested a review from AbdelStark as a code owner November 20, 2023 09:39
src/exchange/order_handler.cairo Outdated Show resolved Hide resolved
src/market/market_utils.cairo Outdated Show resolved Hide resolved
src/oracle/oracle.cairo Outdated Show resolved Hide resolved
src/pricing/error.cairo Show resolved Hide resolved
@Sk8erboi84 Sk8erboi84 merged commit 29efe35 into keep-starknet-strange:main Nov 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants