Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix key field in Order and Withdrawal #676

Merged

Conversation

zarboq
Copy link
Collaborator

@zarboq zarboq commented Jun 24, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Bugfix

What is the current behavior?

Key field is set after event emission

What is the new behavior?

Set field before emitting event

@sparqet sparqet merged commit 000ded5 into keep-starknet-strange:main Jun 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants