Manifest V3 fixes #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox still needs this so we have to put up with the Chrome warning. https://stackoverflow.com/questions/75043889/manifest-v3-background-scripts-service-worker-on-firefox
|
Hey, I haven't had a chance to look over the full Manifest v3 requirements, but does this make us compliant with their requirements in general so that we can attempt to re-apply to have the plugin added? |
Aetherinox
approved these changes
Aug 4, 2024
|
Yes I believe so. There's no linter or validator that I could find so I relied on docs and error messages in Firefox and Chrome when loading the extension |
|
Nice. I need to read up on it more. Most my work was with v2. I've had my face in Electron learning the in's and out's of it in preparation with the split between electron and the remote package. Appreciate the help you're doing with this. It's a lot by myself with the main app. |
|
No worries! Thanks for all your work on the main app. There's a bunch of new stuff here for me as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes left to do after merging #61