feat: support browser environment #629
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intcreator
reviewed
Feb 16, 2023
lib/cron.js
Outdated
| @@ -2,7 +2,7 @@ | |||
| if (typeof define === 'function' && define.amd) { | |||
| define(['luxon'], factory); | |||
| } else if (typeof exports === 'object') { | |||
| module.exports = factory(require('luxon'), require('child_process')); | |||
| module.exports = factory(require('luxon'), (typeof window === 'undefined' ? require('child_process') : {})); | |||
There was a problem hiding this comment.
in browsers, typeof exports is undefined not object, so would the execution even get as far as your logic?
There was a problem hiding this comment.
I'm not sure but this was required for me. My guess it's because im running vue with vite.
34 tasks
sheerlox
changed the title
sheerlox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support cron format testing, next execution calculation, etc. usage in browsers by not requiring child_process.
TODO
shared-node-browser(see refactor!: migrate to TypeScript #694 (review))