Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve context, onTick & onComplete typings #705

Merged

Conversation

sheerlox
Copy link
Collaborator

@sheerlox sheerlox commented Sep 30, 2023

Description

See related issue.

Related Issue

Closes #703.

Motivation and Context

See related issue.

How Has This Been Tested?

added a new test & removed type casting from existing tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change introduces a breaking change, I have added a ! after the type/scope in the title (see the Conventional Commits standard).

@sheerlox sheerlox added type:feature New feature or feature improvement & requests typescript labels Sep 30, 2023
@sheerlox sheerlox self-assigned this Sep 30, 2023
@sheerlox sheerlox marked this pull request as draft October 4, 2023 20:10
@sheerlox
Copy link
Collaborator Author

sheerlox commented Oct 4, 2023

a user pointed out on Discord that the onTick() function types do not correctly reflect it being called with onComplete as an argument.

this is an issue that should probably be handled in this PR before we can consider merging it.

@sheerlox sheerlox added the status:ready Ready to start implementation label Oct 4, 2023
@sheerlox sheerlox force-pushed the feat/703/improve-context-onTick-typings branch from 13e1609 to d6938d8 Compare October 5, 2023 22:26
@sheerlox sheerlox marked this pull request as ready for review October 5, 2023 22:38
@sheerlox sheerlox removed the status:ready Ready to start implementation label Oct 5, 2023
@sheerlox sheerlox changed the title feat: improve context & onTick parameters typings feat: improve context, onTick & onComplete typings Oct 5, 2023
src/time.ts Show resolved Hide resolved
@sheerlox sheerlox merged commit 82c78d7 into kelektiv:main Oct 9, 2023
12 checks passed
@sheerlox sheerlox deleted the feat/703/improve-context-onTick-typings branch October 9, 2023 12:43
ncb000gt pushed a commit that referenced this pull request Oct 9, 2023
## [3.1.0](v3.0.0...v3.1.0) (2023-10-09)

### ✨ Features

* improve context, onTick & onComplete typings ([#705](#705)) ([82c78d7](82c78d7))

### 🚨 Tests

* check at runtime that all tests call expect ([#706](#706)) [skip ci] ([cc4e62f](cc4e62f))

### ♻️ Chores

* **deps:** update semantic-release related packages ([#709](#709)) [skip ci] ([b94a48a](b94a48a))
* reflect repository label changes ([#708](#708)) ([85c9e18](85c9e18))
@ncb000gt
Copy link
Member

ncb000gt commented Oct 9, 2023

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sheerlox sheerlox removed their assignment Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type:feature New feature or feature improvement & requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve context & onTick parameters typings
3 participants