-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve context, onTick & onComplete typings #705
Merged
sheerlox
merged 6 commits into
kelektiv:main
from
sheerlox:feat/703/improve-context-onTick-typings
Oct 9, 2023
Merged
feat: improve context, onTick & onComplete typings #705
sheerlox
merged 6 commits into
kelektiv:main
from
sheerlox:feat/703/improve-context-onTick-typings
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheerlox
added
type:feature
New feature or feature improvement & requests
typescript
labels
Sep 30, 2023
a user pointed out on Discord that the this is an issue that should probably be handled in this PR before we can consider merging it. |
sheerlox
force-pushed
the
feat/703/improve-context-onTick-typings
branch
from
October 5, 2023 22:26
13e1609
to
d6938d8
Compare
sheerlox
changed the title
feat: improve context & onTick parameters typings
feat: improve context, onTick & onComplete typings
Oct 5, 2023
intcreator
reviewed
Oct 6, 2023
intcreator
reviewed
Oct 6, 2023
intcreator
approved these changes
Oct 8, 2023
ncb000gt
pushed a commit
that referenced
this pull request
Oct 9, 2023
## [3.1.0](v3.0.0...v3.1.0) (2023-10-09) ### ✨ Features * improve context, onTick & onComplete typings ([#705](#705)) ([82c78d7](82c78d7)) ### 🚨 Tests * check at runtime that all tests call expect ([#706](#706)) [skip ci] ([cc4e62f](cc4e62f)) ### ♻️ Chores * **deps:** update semantic-release related packages ([#709](#709)) [skip ci] ([b94a48a](b94a48a)) * reflect repository label changes ([#708](#708)) ([85c9e18](85c9e18))
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See related issue.
Related Issue
Closes #703.
Motivation and Context
See related issue.
How Has This Been Tested?
added a new test & removed type casting from existing tests.
Types of changes
Checklist:
!
after the type/scope in the title (see the Conventional Commits standard).