fix: re-add runOnce property to CronJob #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intcreator
reviewed
Oct 26, 2023
This was referenced Oct 26, 2023
intcreator
approved these changes
Oct 26, 2023
ncb000gt
pushed a commit
that referenced
this pull request
Oct 26, 2023
## [3.1.5](v3.1.4...v3.1.5) (2023-10-26) ### 🐛 Bug Fixes * detect multiple zeros as an invalid step ([#743](#743)) [skip ci] ([b0bf677](b0bf677)) * re-add runOnce property to CronJob ([#751](#751)) ([a61d8c9](a61d8c9)) ### 📚 Documentation * **readme:** API documentation overhaul ([#716](#716)) [skip ci] ([23fb0a3](23fb0a3)) ### ⚙️ Continuous Integrations * **action:** update actions/setup-node action to v4 ([#749](#749)) ([ef850f3](ef850f3)) ### ♻️ Chores * **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v18 ([#747](#747)) ([5ff1cf8](5ff1cf8)) * **deps:** update dependency sinon to v17 ([#748](#748)) ([9d61ff9](9d61ff9)) * **deps:** update linters ([7bdc726](7bdc726)) * improve ossf scorecard's score ([#715](#715)) [skip ci] ([1284df4](1284df4))
|
🎉 This PR is included in version 3.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sheerlox
added a commit
to sheerlox/node-cron
that referenced
this pull request
Oct 29, 2023
This reverts commit a61d8c9.
9 tasks
sheerlox
added a commit
to sheerlox/node-cron
that referenced
this pull request
Oct 29, 2023
This reverts commit a61d8c9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add
runOnceback to CronJob, this time as a getter to shadowingthis.cronTime.realDatevalue.Related Issue
#740 (comment)
Motivation and Context
removing this property was a breaking change.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).