Add http basic authentication support #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitjcize
force-pushed
the
master
branch
4 times, most recently
from
60f596b to
0ba5f81
Compare
hitripod
reviewed
Apr 23, 2018
web/web.go
Outdated
| mux.HandleFunc("/api/urls/", func(w http.ResponseWriter, r *http.Request) { | ||
| apiURLs(ctx, w, r) | ||
| }) | ||
| auth := NewBasicAuth("cobinhood", htpasswd) |
There was a problem hiding this comment.
- cobinhood?
- what if I want to disable the auth?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HTTP basic auth support. Account/password is read from a htpassword file.
To enhance security, only the bcrypt encryption scheme is supported.
The htpasswd file can be generated with the following command:
htpasswd -B -c htpasswd usernameThe
auth.gofile is taken from the chromiumos project and I'm the original author of the file.