Allow path after a shortcut: go/short/foobar #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows adding additional path to a shortened URL. For example, if go/short redirects to http://example.com, go/short/foobar will redirect to http://example.com/foobar. An example usage is to shorten Google Docs headings. go/mydoc can redirect to a document. go/mydoc/#heading=h.asdfgh123456 can then redirect to a specific heading in the doc. This feature is supported in the original golinks at Google. Next step: Create a chrome extension that links to the go/ server and shortens a given link based on the shortcuts already registered
|
shouldn't we have a special placeholder defined in the route, instead of simply appending ? I get that appending cover most cases but I wonder... |
|
there is a compilation error in api.go, need to update the 3 calls to parseName |
| @@ -58,7 +58,7 @@ func getDefault(ctx *context.Context, w http.ResponseWriter, r *http.Request) { | |||
| } | |||
|
|
|||
| http.Redirect(w, r, | |||
| rt.URL, | |||
| rt.URL+s, | |||
There was a problem hiding this comment.
looks like s contains the leading slash... i don't think it should.
you might want to add after an param= at the end, but now I am getting param=/foobar which is not what I want.
There was a problem hiding this comment.
I have added +1 to parseName function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows adding additional path to a shortened URL. For example, if
go/short redirects to http://example.com, go/short/foobar will redirect
to http://example.com/foobar.
An example usage is to shorten Google Docs headings. go/mydoc can
redirect to a document. go/mydoc/#heading=h.asdfgh123456 can then
redirect to a specific heading in the doc.
This feature is supported in the original golinks at Google.
Next step: Create a chrome extension that links to the go/ server and
shortens a given link based on the shortcuts already registered