-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cfn): add plugin #584
base: dev
Are you sure you want to change the base?
feat(cfn): add plugin #584
Conversation
tests should not fail, I only added a new plugin, so maybe tests are flakey? something broken on master? |
Nice - looks very clean! I was thinking along the same lines that we could add token types to the Ruamel YAML constructor. Don't worry about the test failure - that's a behavior change in python 3.12 and 3.13 in the ipaddress library I need to address. |
good to know on the test bit :) what I will say that to make this actually functional I need to write a good portion of boilerplate, because now I just "ignored" these objects. also where there are two predicates I am not a Ruamel master so this is me and a GPT of your choice's doing. |
@georgettica I'm starting to work on the next release. Do you think this is close to being ready or should we hold off with this parser? Thanks! |
Let's hold off, just because I was waiting for another support / guidance. I'll give it another push later at some point and let you know the status when I do |
I see I didn't update yet, sorry for not checking on this sooner, I hope I will get to it but if someone wants to take it over they are welcome (a big change :/) |
this is the initial work, we can start discussing from here #580