Try harder to get the git root directory the first time GitGotoDiff is called #524
+14
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that we always prompt the user for the root git directory. GitWindowCommand has a nice little addition to its get_working_dir() method to try to get an open folder from the window as a last ditch effort. This change refactors the code from GitWindowCommand.get_working_dir() out into a reusable method named get_open_folder_from_window(). GitGotoDiff can now use the new get_open_folder_from_window() method to try to get a git root directory if one hasn't been set yet.