Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nieuwe parameters aan entry toegevoegd voor Environment, ActivationBefore en AdditionalLicenseOptions #4

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

emilyborgers
Copy link

@emilyborgers emilyborgers commented Mar 22, 2021

Momenteel worden de parameters Environment, ActivationBefore en AdditionalLicenseOptions niet opgenomen omdat deze complexe objecten waren en nog niet gemaakt waren.

Hierom zijn deze 3 nu wel toegevoegd maar nog zonder ENUM voor de exacte mogelijkheden van Environment en AdditionalLicenseOptions

@wimmuskee
Copy link
Member

geen project prefixes in de commit messages gaarne, die prefixes betekenen niets buiten Kennisnet

@emilyborgers emilyborgers changed the title CATWEB-37: Nieuwe parameters toegevoegd Nieuwe parameters aan entry toegevoegd voor Environment, ActivationBefore en AdditionalLicenseOptions Mar 23, 2021
Emily Borgers and others added 5 commits March 23, 2021 15:59
Added trailing new lines where missing.
…instead of MapValueToStringArray as that is possible and cleaner (at least, debatable, but its in line with others)
…_Parameters

Changed AdditionalLicenseOptions mapper to use MapArrayToStringArray …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants