Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update 'validates url is valid' test #50

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

trillium
Copy link
Contributor

@trillium trillium commented Nov 19, 2024

Fixes #49

What:

Switches validates url is valid test to use a regex that passes for changed new URL() error message from node 15 to node 16

Why:

Test suite fails when asked to rerun all tests

How:

Pass a regex that will match the error message Invalid URL (error message node 16+) and Invalid URL: blah (error message node 15-) into the tests toThrow().

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged

@kentcdodds kentcdodds merged commit e69b3d5 into kentcdodds:main Nov 19, 2024
5 checks passed
@trillium trillium deleted the ts.update_test_error_message branch November 19, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Test "validates url is valid" breaks between node versions 15 and 16
2 participants