Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] heatmap renders nothing with black color or duplicate color #2978

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

igorDykhta
Copy link
Collaborator

  • scale.invertExtent(level) returns values for the first encountered color in the range and doesn't work with duplicate values. And as result Mapbox Heatmap crashes during verification.

  • fixes heatmaps with black color

  • fixes heatmaps with cyclical palettes

  • fixes the issue for non-unique colors from custom palettes.

  • no visual differences

Screenshot 2025-02-06 at 3 39 23 AM

@igorDykhta igorDykhta requested a review from ilyabo February 6, 2025 01:46
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta igorDykhta merged commit f8fbf24 into master Feb 6, 2025
8 checks passed
@igorDykhta igorDykhta deleted the igr/fix-heatmap-unique-colors branch February 6, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants