Add AugMix #407

quantumalaviya · 2022-05-02T18:36:01Z

closes #40
Moreover, added util functions from keras to support translation and rotation layers.

quantumalaviya · 2022-05-02T18:40:42Z

Currently, I have only implemented the main layers used in the implementation ( color, contrast, brightness, sharpness is not implemented)

I have also re-coded Posterization and Solarization as part of this layer because tensor inputs weren't compatible.

Lastly, the layer isn't vectorized. I believe it's better this way for now and we can further vectorized the layer in a follow-up layer (if possible)

quantumalaviya · 2022-05-02T18:43:26Z

Also, this implementation is highly inspired by @szacho's wonderful implementation.

Thanks!

LukeWood · 2022-05-02T22:27:45Z

Also, this implementation is highly inspired by @szacho's wonderful implementation.

Thanks!

Be sure to include this in references! Thanks!

LukeWood · 2022-05-02T22:33:23Z

Currently, I have only implemented the main layers used in the implementation ( color, contrast, brightness, sharpness is not implemented)

I have also re-coded Posterization and Solarization as part of this layer because tensor inputs weren't compatible.

Lastly, the layer isn't vectorized. I believe it's better this way for now and we can further vectorized the layer in a follow-up layer (if possible)

Thanks for the PR @quantumalaviya. I will review it as soon as I can.

examples/layers/preprocessing/aug_mix_demo.py

keras_cv/layers/preprocessing/aug_mix.py

LukeWood

Some preliminary comments @quantumalaviya!

Great work, this is coming along great. Definitely a substantial effort, and happy to review again once we have the comments above addressed. Thanks!

keras_cv/layers/preprocessing/aug_mix.py

quantumalaviya · 2022-05-12T20:30:33Z

Are we keeping this on hold until #431 is resolved? @LukeWood

LukeWood · 2022-05-17T17:25:56Z

It's not the worst thing in the world to repeat yourself occasionally in code, but if possible we should use our layers' _augment_image methods with a static provided transformation.

If this isn't possible let me know

LukeWood · 2022-05-17T17:25:56Z

It's not the worst thing in the world to repeat yourself occasionally in code, but if possible we should use our layers' _augment_image methods with a static provided transformation.

If this isn't possible let me know

quantumalaviya · 2022-05-17T17:42:57Z

I can't exactly think of a way to reduce the lines of code here. I considered using it for the sample_level calls but I don't think there will be a considerable reduction. To my understanding, this method was more useful in cases where labels and augmentations had to share a common transformation.

If you have something specific in mind, let me know.

LukeWood · 2022-05-17T18:47:38Z

Sounds good, let me play around with it a bit more! Thanks!

keras_cv/layers/preprocessing/aug_mix.py

LukeWood · 2022-06-10T18:12:55Z

Thanks for the hard work on this one @quantumalaviya ! it will be a wonderful feature soon!

keras_cv/layers/preprocessing/aug_mix.py

quantumalaviya · 2022-06-12T16:48:17Z

Also fixed sample usages in FMix and MixUp in docstrings

examples/layers/preprocessing/aug_mix_demo.py

LukeWood

minor changes, think I believe it will look pretty good.

…nto add_augmix

LukeWood

Wonderful!

Can you re-run the example script with all of the changes to ensure it still works as we expect? Then if so, I believe we are ready to go!

keras_cv/layers/preprocessing/aug_mix.py

LukeWood · 2022-06-14T20:49:30Z

Thank you @quantumalaviya for the contribution! This is great, and the API looks good.

In the future, we may want to refactor the helper methods to be reused in their corresponding KPLs, but this is an implementation detail not an API change - so this is great

* adding augmix * add augmix with demo * add augmix test * add augmix * Update aug_mix.py * Update aug_mix.py * Update aug_mix_demo.py * updating augmix with changes * init commit with review comments * fix linting issues * removing RandomShear assignment in constructor * review comments part 2 * review comments part 2 fix * review comments part 3 * change variable names * fix lint issues * edit serialization test * edit demo to use utils * Update augmix Co-authored-by: Luke Wood <[email protected]>

quantumalaviya mentioned this pull request May 2, 2022

[AutoAugment] Add Rotate operation. #402

Closed

LukeWood self-requested a review May 2, 2022 22:27

quantumalaviya mentioned this pull request May 4, 2022

AugMix image augmentation #40

Closed

innat reviewed May 4, 2022

View reviewed changes

examples/layers/preprocessing/aug_mix_demo.py Outdated Show resolved Hide resolved

innat reviewed May 4, 2022

View reviewed changes

keras_cv/layers/preprocessing/aug_mix.py Outdated Show resolved Hide resolved

LukeWood suggested changes May 11, 2022

View reviewed changes

quantumalaviya mentioned this pull request May 12, 2022

Equalization channel dimension is not calculated during trace time #431

Open

LukeWood reviewed Jun 7, 2022

View reviewed changes

keras_cv/layers/preprocessing/aug_mix.py Outdated Show resolved Hide resolved

LukeWood suggested changes Jun 7, 2022

View reviewed changes

keras_cv/layers/preprocessing/aug_mix.py Outdated Show resolved Hide resolved

keras_cv/layers/preprocessing/aug_mix.py Outdated Show resolved Hide resolved

keras_cv/layers/preprocessing/aug_mix.py Outdated Show resolved Hide resolved

quantumalaviya force-pushed the add_augmix branch from edb7d87 to 1ff4491 Compare June 9, 2022 17:45

quantumalaviya and others added 8 commits June 9, 2022 23:18

adding augmix

5160fab

add augmix with demo

e9f0d21

add augmix test

24a321c

add augmix

a6d4785

Update aug_mix.py

a3b28ed

Update aug_mix.py

804ff6f

Update aug_mix_demo.py

e3d2dee

updating augmix with changes

3d2ca52

quantumalaviya force-pushed the add_augmix branch from 1ff4491 to 3d2ca52 Compare June 9, 2022 17:49

quantumalaviya added 2 commits June 9, 2022 23:21

init commit with review comments

b70688a

fix linting issues

512c425

quantumalaviya requested a review from LukeWood June 9, 2022 18:26

LukeWood suggested changes Jun 9, 2022

View reviewed changes

keras_cv/layers/preprocessing/aug_mix.py Outdated Show resolved Hide resolved

removing RandomShear assignment in constructor

d934d96

quantumalaviya requested a review from LukeWood June 10, 2022 17:35

LukeWood reviewed Jun 10, 2022

View reviewed changes

keras_cv/layers/preprocessing/aug_mix.py Outdated Show resolved Hide resolved

LukeWood suggested changes Jun 10, 2022

View reviewed changes

quantumalaviya added 2 commits June 11, 2022 02:30

review comments part 2

3f98242

review comments part 2 fix

73e014b

quantumalaviya requested a review from LukeWood June 10, 2022 21:28

LukeWood suggested changes Jun 11, 2022

View reviewed changes

review comments part 3

768ddaf

quantumalaviya requested a review from LukeWood June 12, 2022 16:48

LukeWood reviewed Jun 13, 2022

View reviewed changes

examples/layers/preprocessing/aug_mix_demo.py Outdated Show resolved Hide resolved

LukeWood suggested changes Jun 13, 2022

View reviewed changes

quantumalaviya added 4 commits June 14, 2022 23:12

change variable names

f1f6e0c

fix lint issues

71cd719

edit serialization test

a741bd2

Merge branch 'master' of https://github.com/quantumalaviya/keras-cv i…

25d6bf9

…nto add_augmix

LukeWood suggested changes Jun 14, 2022

View reviewed changes

keras_cv/layers/preprocessing/aug_mix.py Outdated Show resolved Hide resolved

edit demo to use utils

db3570c

quantumalaviya requested a review from LukeWood June 14, 2022 18:59

Update augmix

0f57e32

LukeWood merged commit 0a9640e into keras-team:master Jun 14, 2022

freedomtan pushed a commit to freedomtan/keras-cv that referenced this pull request Jul 20, 2023

Remove a rogue print statement (keras-team#407)

534e60b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AugMix #407

Add AugMix #407

quantumalaviya commented May 2, 2022

quantumalaviya commented May 2, 2022

quantumalaviya commented May 2, 2022

LukeWood commented May 2, 2022

LukeWood commented May 2, 2022

LukeWood left a comment

quantumalaviya commented May 12, 2022

LukeWood commented May 17, 2022

LukeWood commented May 17, 2022

quantumalaviya commented May 17, 2022

LukeWood commented May 17, 2022

LukeWood commented Jun 10, 2022

quantumalaviya commented Jun 12, 2022

LukeWood left a comment

LukeWood left a comment

LukeWood commented Jun 14, 2022

Add AugMix #407

Add AugMix #407

Conversation

quantumalaviya commented May 2, 2022

quantumalaviya commented May 2, 2022

quantumalaviya commented May 2, 2022

LukeWood commented May 2, 2022

LukeWood commented May 2, 2022

LukeWood left a comment

Choose a reason for hiding this comment

quantumalaviya commented May 12, 2022

LukeWood commented May 17, 2022

LukeWood commented May 17, 2022

quantumalaviya commented May 17, 2022

LukeWood commented May 17, 2022

LukeWood commented Jun 10, 2022

quantumalaviya commented Jun 12, 2022

LukeWood left a comment

Choose a reason for hiding this comment

LukeWood left a comment

Choose a reason for hiding this comment

LukeWood commented Jun 14, 2022