Updates Keras CV - Classification guide for Keras 3 #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampathweb
requested review from
fchollet,
MarkDaoust and
pcoet
as code owners
sampathweb
force-pushed
the
keras-cv-classifier
branch
from
9f0e68b to
916402f
Compare
fchollet
reviewed
Nov 29, 2023
| @@ -496,10 +599,45 @@ keras_cv.visualization.plot_image_gallery( | |||
| ) | |||
| ``` | |||
|
|
|||
| <div class="k-default-codeblock"> | |||
| ``` | |||
| WARNING:tensorflow:Using a while_loop for converting RngReadAndSkip cause there is no registered converter for this op. | |||
There was a problem hiding this comment.
Do you know the cause of all these warnings? Is this something we could fix?
There was a problem hiding this comment.
Yes, its coming from the call to random_cutout -
import numpy as np
import keras_cv
x = np.random.rand(1, 5, 5, 3)
random_cutout = keras_cv.layers.RandomCutout(width_factor=0.4, height_factor=0.4)
# Call of `random_cutout` causes this warning
_ = random_cutout(x)
From this line - https://github.com/keras-team/keras-cv/blob/master/keras_cv/utils/fill_utils.py#L84
images = tf.where(is_rectangle, fill_values, images)
is_rectangleshape is(1, 5, 5, 1)(Bool)fill_valuesshape is(1, 5, 5, 3)(float32)imagesshape is(1, 5, 5, 3)(float32)
Not sure why its happening.
There was a problem hiding this comment.
It doesn't look actionable. Please remove the warnings from the md file manually, we'll merge.
pcoet
reviewed
Nov 30, 2023
| @@ -21,25 +21,43 @@ | |||
| - Fine-tuning a pretrained backbone | |||
| - Training a image classifier from scratch | |||
|
|
|||
| KerasCV uses Keras 3 to work with any of TensorFlow, Pytorch and Jax. In the | |||
There was a problem hiding this comment.
"TensorFlow, Pytorch and Jax." -> "TensorFlow, PyTorch, or Jax." (Note spelling of "PyTorch".)
pcoet
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.