-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating Nnclr to Keras-3[TF BackEnd] #1730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @aditya02shah !!
My suggestion for tf.image.crop_and_resize()
is to use the following two functions in Keras 3
Everything else looks good!
@divyashreepathihalli, thank you for your feedback! I considered your suggestion and opted to replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thank you! please generate the .md and .ipynb files.
@divyashreepathihalli I have explicitly set the TensorFlow backend as the default, as utilizing the JAX and PyTorch backends results in errors such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example is expected to be TF-only since it uses the GradientTape.
LGTM, thank you!
Actually, it turns out that the files for this example were generated using Keras 2. Can you regenerate using Keras 3? |
This PR migrates the
nnclr
example to Keras 3.0 as requested in keras-team/keras-cv#2211.tf.data
andtf.image.crop_and_resize()
function.torch
andjax
backends and works fine.