-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenVino BackEnd] support np.diff for ov BackEnd #20950
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20950 +/- ##
==========================================
- Coverage 82.35% 77.50% -4.86%
==========================================
Files 561 561
Lines 52992 53261 +269
Branches 8207 8250 +43
==========================================
- Hits 43644 41279 -2365
- Misses 7337 10044 +2707
+ Partials 2011 1938 -73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@rkazants can you please review and tell me what can I improve and why am I failing this case? |
@fchollet hello sir can I get a little help on this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formating test is failing. You might have trailing whitespace somewhere. did you run bash shell\format.sh
locally in the root dir of your keras fork?
No sir i haven't |
Can you do it? It will automatically rearrange your code so it passes the formatting test. Do you need any help with anything? |
No sir, thanks. Could you please review my code once? I've implemented the logic, but I feel like it might not be fully utilizing OpenVINO's capabilities. Your feedback would be greatly appreciated. |
@nikolasavic3 Sir, why am I getting this error? |
@fchollet, could you please review?