Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenVino BackEnd] support np.diff for ov BackEnd #20950

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chiruu12
Copy link

@fchollet, could you please review?

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.50%. Comparing base (1eee113) to head (5bac831).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/numpy.py 89.74% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20950      +/-   ##
==========================================
- Coverage   82.35%   77.50%   -4.86%     
==========================================
  Files         561      561              
  Lines       52992    53261     +269     
  Branches     8207     8250      +43     
==========================================
- Hits        43644    41279    -2365     
- Misses       7337    10044    +2707     
+ Partials     2011     1938      -73     
Flag Coverage Δ
keras 77.34% <89.74%> (-4.83%) ⬇️
keras-jax ?
keras-numpy 58.77% <0.00%> (-0.15%) ⬇️
keras-openvino 32.64% <89.74%> (+0.04%) ⬆️
keras-tensorflow 64.43% <0.00%> (-0.18%) ⬇️
keras-torch 64.00% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chiruu12
Copy link
Author

@rkazants can you please review and tell me what can I improve and why am I failing this case?

@chiruu12
Copy link
Author

@fchollet hello sir can I get a little help on this one?

Copy link
Contributor

@nikolasavic3 nikolasavic3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formating test is failing. You might have trailing whitespace somewhere. did you run bash shell\format.sh locally in the root dir of your keras fork?

@chiruu12
Copy link
Author

No sir i haven't

@nikolasavic3
Copy link
Contributor

Can you do it? It will automatically rearrange your code so it passes the formatting test. Do you need any help with anything?

@chiruu12
Copy link
Author

No sir, thanks. Could you please review my code once? I've implemented the logic, but I feel like it might not be fully utilizing OpenVINO's capabilities. Your feedback would be greatly appreciated.

@chiruu12
Copy link
Author

@nikolasavic3 Sir, why am I getting this error?

@chiruu12 chiruu12 closed this Feb 25, 2025
@chiruu12 chiruu12 reopened this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants