Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenVINO Backend] Support np.diag #20967

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

srinjoydutta03
Copy link

@srinjoydutta03 srinjoydutta03 commented Feb 26, 2025

  • Implemented np.diag for openvino backend
  • Closes #29115

CC: @rkazants

Copy link

google-cla bot commented Feb 26, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.43%. Comparing base (da10cf3) to head (a2911f5).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/numpy.py 73.33% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20967   +/-   ##
=======================================
  Coverage   82.42%   82.43%           
=======================================
  Files         561      561           
  Lines       53226    53247   +21     
  Branches     8244     8250    +6     
=======================================
+ Hits        43871    43892   +21     
- Misses       7338     7344    +6     
+ Partials     2017     2011    -6     
Flag Coverage Δ
keras 82.24% <73.33%> (+0.01%) ⬆️
keras-jax 63.98% <0.00%> (-0.02%) ⬇️
keras-numpy 58.80% <0.00%> (-0.01%) ⬇️
keras-openvino 32.65% <73.33%> (+0.05%) ⬆️
keras-tensorflow 64.42% <0.00%> (-0.05%) ⬇️
keras-torch 64.04% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srinjoydutta03
Copy link
Author

I'm not sure why tests for diagflat and diagonal are getting invoked, when I only removed diag from exclude_concrete_tests.txt file. Please help me resolve this.

@srinjoydutta03
Copy link
Author

@rkazants Please review whenever you can can. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue][Keras 3 OpenVINO Backend]: Support numpy.diag operation
3 participants