Hyper-X fix #213
Merged
Hyper-X fix #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added motherboard_product technique to replace old motherboard techniques (25 of score)
Added VIRTUAL_PROCESSORS to the Windows list technique
Added compatibility for 32 bits in virtual_processors technique
Reduced physical port connectors score to 10 as previously discussed
Removed VPC_board and hyperv_board technique, they are not reliable because Microsoft motherboard exists
Fixed Hyper-X detecting Microsoft motherboards as Hyper-V VMs
Fixed Physical port connectors technique from flagging Surface Pro devices
Fixed GetThreadsUsingWMI returning an incorrect value in case of failure
Fixed audio_devices using a different WMI threading mode than the rest of techniques
Improved WMI wrapper to handle multiple WMI initialization modes, previously it was returning an error if WMI was already initialized with another threading mode
Improved every technique that uses WMI to avoid WMI reinitialization, improving speed
Changed VM brand description functions in CLI to be compatible with C++ 11 (string_view removed from function parameter)