Fix favicons for normal tabs (history and bookmarks worked)

fixes #270
kesselborn · Jan 2, 2019 · 999f576 · 999f576
1 parent aeac771
commit 999f576
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/conex-components.js b/conex-components.js
@@ -125,14 +125,18 @@ const renderEntry = function(url, title, id, favIconUrl, drawBookmarkIcon, drawA
       ]),
     ]);
 
-  if (bg.settings['show-favicons'] && favIconUrl && favIconUrl.startsWith('http')) {
-    fetch(favIconUrl, { method: "GET", }).then(res => {
-      if (res.ok) {
-        $1('img', element).src = favIconUrl;
-      } else {
-        console.error(`error fetching favicon for ${favIconUrl} -- response was`, res);
-      }
-    }, e => console.error(`error fetching ${favIconUrl}: ${e}`));
+  if (bg.settings['show-favicons'] && favIconUrl) {
+    if(favIconUrl.startsWith('http')) {
+      fetch(favIconUrl, { method: "GET", }).then(res => {
+        if (res.ok) {
+          $1('img', element).src = favIconUrl;
+        } else {
+          console.error(`error fetching favicon for ${favIconUrl} -- response was`, res);
+        }
+      }, e => console.error(`error fetching ${favIconUrl}: ${e}`));
+    } else if(favIconUrl.startsWith('data:image')) {
+      $1('img', element).src = favIconUrl;
+    }
   }
 
   return element;