fix(ui): skeletons based on type like for chart and table. #7417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-geller
approved these changes
Feb 27, 2025
|
When you throttle the network in the browser, you can catch a moment when the loading skeletons are not shown, but the no data ones are, for a quick moment, before it shows proper data. Could you try to catch that and prevent it @Piyush-r-bhaskar? Screencast.from.2025-02-28.11-50-52.webm |
|
Ahha .right Milos. Thank you! I will check this. |
fix.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6469
skeleton.mp4