fix(sendgrid): Sendgrid Email notification returns errors but task ma…

…rked as succeeded (#179)

fix api

throw exception if status code is not 2xx

update test

#178

src/main/java/io/kestra/plugin/notifications/sendgrid/SendGridMailSend.java

@@ -141,14 +141,14 @@ public SendGridMailSend.Output run(RunContext runContext) throws Exception {
 
         Logger logger = runContext.logger();
 
-        logger.debug("Sending an email to {}", to);
+        logger.debug("Sending an email to {}", runContext.render(to));
 
         Mail mail = new Mail();
 
-        Personalization personalization = new Personalization();
-
         Email fromEmail = new Email(runContext.render(this.from));
-        personalization.setFrom(fromEmail);
+        mail.setFrom(fromEmail);
+
+        Personalization personalization = new Personalization();
 
         runContext.render(this.to).stream().map(Email::new).forEach(personalization::addTo);
 
@@ -196,6 +196,10 @@ public SendGridMailSend.Output run(RunContext runContext) throws Exception {
         Map<String, String> headers = api.getHeaders();
         int statusCode = api.getStatusCode();
 
+        if (statusCode/100 != 2) {
+          throw new RuntimeException("SendGrid API failed with status code: " + statusCode + " and body: " + body);
+        }
+
         return Output.builder().body(body).headers(headers).statusCode(statusCode).build();
     }
 

src/test/java/io/kestra/plugin/notifications/sendgrid/SendGridMailExecutionTest.java

@@ -41,6 +41,6 @@ void init() throws IOException, URISyntaxException {
     void testFlow() throws TimeoutException, QueueException {
         Execution execution = runnerUtils.runOne(null, "io.kestra.tests", "sendgrid");
         assertThat(execution.getTaskRunList(), hasSize(2));
-        assertThat(execution.getTaskRunList().get(1).getState().getCurrent(), is(State.Type.SUCCESS));
+        assertThat(execution.getTaskRunList().get(1).getState().getCurrent(), is(State.Type.FAILED));
     }
 }

src/test/java/io/kestra/plugin/notifications/sendgrid/SendGridMailSendTest.java

@@ -29,6 +29,7 @@
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.is;
 
+@Disabled("Need a SendGrid API key")
 @KestraTest
 public class SendGridMailSendTest {
 
@@ -86,7 +87,6 @@ private RunContext getRunContext() {
     }
 
     @Test
-    @Disabled("Need a SendGrid API key")
     @DisplayName("Send email with html and plain text contents")
     void sendEmail() throws Exception {
         RunContext runContext = getRunContext();
@@ -115,7 +115,7 @@ void sendEmail() throws Exception {
 
         SendGridMailSend.Output output = mailSend.run(runContext);
 
-        assertThat(output.getStatusCode(), is(200));
+        assertThat(output.getStatusCode(), is(202));
 
         String body = IOUtils.toString(output.getBody().getBytes(), String.valueOf(StandardCharsets.UTF_8));