Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented a way to delete all objects with classname #45

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

iNikitaGricenko
Copy link
Contributor

@iNikitaGricenko iNikitaGricenko commented Aug 21, 2024

What changes are being made and why?


How the changes have been QAed?

tasks:
  - id: insertWeaviateMovies
    type: io.kestra.plugin.weaviate.BatchCreate
    url: "http://localhost:51525"
    className: Movies
    objects:
      - name: "The Shawshank Redemption"
        description: "Over the course of several years, two convicts form a friendship, seeking consolation and, eventually, redemption through basic compassion."
        category: "Drama"
      - name: "The Godfather"
        description: "Don Vito Corleone, head of a mafia family, decides to hand over his empire to his youngest son Michael. However, his decision unintentionally puts the lives of his loved ones in grave danger."
        category: "Crime"
      - name: "The Dark Knight"
        description: "When the menace known as the Joker wreaks havoc and chaos on the people of Gotham, Batman must accept one of the greatest psychological and physical tests of his ability to fight injustice."
        category: "Action"
        
  - id: deleteWeaviateMovie
    type: io.kestra.plugin.weaviate.Delete
    url: "http://localhost:51525"
    className: Movies
    filter:
      name: "The Shawshank Redemption"
      
  - id: deleteAllWeaviateMovies
    type: io.kestra.plugin.weaviate.Delete
    url: "http://localhost:51525"
    className: Movies

@iNikitaGricenko iNikitaGricenko changed the title Implement a way to delete all objects with classname Implemented a way to delete all objects with classname Aug 21, 2024
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@loicmathieu loicmathieu merged commit 3096e85 into kestra-io:master Aug 21, 2024
1 check passed
@iNikitaGricenko
Copy link
Contributor Author

@loicmathieu Sorry, in my PR description was text "Fixes #13", i'm not quite sure how it went in there, but this PR doesn't fix that ticket, as i didn't manage to reproduce this issue using local environment

@loicmathieu
Copy link
Member

I added there as I thought it was a fix for the issue.
I'll reopen it then, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants