-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to ignore the Match directive #65
base: master
Are you sure you want to change the base?
Add the possibility to ignore the Match directive #65
Conversation
@kevinburke could you take a look whenever you have a chance? thanks |
We can't even use the go mode we can't override |
I was just testing this out in my fork of the repo and found a bug. Line 431 of |
Found one more bug in this. The To fix it, the |
This PR tries to make #6 less of an issue.
The
go-git-v5
lib uses your nice ssh parser however in Alma 8/9 and most of RHEL there is thisMatch
directive in the default ssh config and it completely breaks all the git operation in these OSesWhile someone brave enough makes the implementation for parsing the Match I thought ignoring it would be enough.
Ideally we shouldn't be passing so many params to functions but I didn't want to refactor to much stuff.
After this PR is merged you could ignore the directive like this:
ssh_config.DefaultUserSettings.IgnoreMatchDirective = true
This