Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data importer for factions does not take factions with sub-factions into account #495

Open
maxdekrieger opened this issue Jan 19, 2023 · 2 comments

Comments

@maxdekrieger
Copy link
Contributor

Title says it all, this prevents Maruuk Centaur and Valdrakken Accord from being added automatically, as found out in #493.

Line 86 and 87 of the importer have to be changed into something more elaborate.

if not children:
self.dbc_faction[int(rep['ID'])] = rep

@Leomelati
Copy link
Contributor

Hey @maxdekrieger

Was this one solved on the recent PR? Do you think it can be closed?

@maxdekrieger
Copy link
Contributor Author

It wasn't solved in the recent PR, I just added the non-leaf factions manually so this should still be open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants