Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dragonflight factions #493

Merged
merged 7 commits into from
Feb 5, 2023

Conversation

maxdekrieger
Copy link
Contributor

@maxdekrieger maxdekrieger commented Jan 17, 2023

This one is not as easy as I'd hoped.

TODO Back-end:

  • Run data import for factions
  • Figure out why data import is not importing all factions (Centaurs, Valdrakken accord, etc.)
  • Change DataImporter to automatically import maxRenown.

TODO Front-end:

  • Make renown 25 and 30 fit into the default line width for reputations
  • Change "Renown 0x" to "Renown x"
  • Fix color with sliding scale for renown factions

Development Notes:
Puzzling with the CSV build files gave me the following information

  • The dragonflight factions with renown have property flag set to 2
  • Main dragonflight factions are also covenants
  • Reputation upgrades are visible under renown rewards csv (possibility for figuring out max-renown!)

@maxdekrieger
Copy link
Contributor Author

Update: fixed my local branch so it's not conflicting anymore (hopefully)

@seirl
Copy link
Collaborator

seirl commented Jan 18, 2023

Thanks for doing this. Btw we can automatically get the max renown level by checking the covenant rewards table.

@maxdekrieger
Copy link
Contributor Author

maxdekrieger commented Jan 19, 2023

Is it possible the maruuk centaur and valdrakken accord weren't added by default because they have sub-reputations? That's my guess according to some debugging and figuring out the reputations fixer. I've added them manually for now.

@seirl
Copy link
Collaborator

seirl commented Jan 19, 2023

Yes, that's very likely. I have only been adding tree leaves for now because intermediate reps were weird. But we could fix that. Can you file a bug?

@maxdekrieger
Copy link
Contributor Author

Done: #495

@maxdekrieger
Copy link
Contributor Author

Update: with the latest commit, the renown reputations now look like this:
image.

On my laptop I had an issue where the renown reps would be wider than the other reputation, most likely due to the amount of small boxes, but I don't experience this on my desktop; will investigate later.

Also the data importer could still be improved by automatically inferring maxRenown based on the covenant rewards CSV.

@maxdekrieger maxdekrieger marked this pull request as ready for review January 28, 2023 16:18
@maxdekrieger
Copy link
Contributor Author

Updated the reputations fixer to import the maximum renown from the correct DBC files and rebased the branch. It's ready for review now :)

@maxdekrieger maxdekrieger changed the title [WIP] Add Dragonflight factions Add Dragonflight factions Jan 28, 2023
@seirl seirl merged commit 77c19bf into kevinclement:master Feb 5, 2023
@maxdekrieger maxdekrieger deleted the add-dragonflight-factions branch September 6, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants