Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit check-xml test #300

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Conversation

Zehvogel
Copy link
Contributor

@Zehvogel Zehvogel commented Nov 10, 2023

BEGINRELEASENOTES

  • Add pre-commit check-xml test to validate compact files

ENDRELEASENOTES

to avoid futher issues like: #297

Needs a bit of work to run through in

full output of pre-commit run -a

SiD/compact/SiD_o1_v01/Support.xml: Failed to xml parse (SiD/compact/SiD_o1_v01/Support.xml:11:0: junk after document element)
ILD/compact/ILD_o2_v01/ILD_o2_v01.xml: Failed to xml parse (ILD/compact/ILD_o2_v01/ILD_o2_v01.xml:451:11: not well-formed (invalid token))
SiD/compact/SiD_o1_v01/HCalBarrel_o1_v03_00.xml: Failed to xml parse (SiD/compact/SiD_o1_v01/HCalBarrel_o1_v03_00.xml:42:5: not well-formed (invalid token))
SiD/compact/SiD_o2_v03/BeamPipe.xml: Failed to xml parse (SiD/compact/SiD_o2_v03/BeamPipe.xml:3:0: junk after document element)
SiD/compact/SiD_o1_v01/BeamPipe.xml: Failed to xml parse (SiD/compact/SiD_o1_v01/BeamPipe.xml:3:0: junk after document element)
SiD/compact/SiD_o2_v02/BeamPipe.xml: Failed to xml parse (SiD/compact/SiD_o2_v02/BeamPipe.xml:3:0: junk after document element)
FCCee/IDEA/compact/IDEA_o1_v01/IDEA_o1_v01.xml: Failed to xml parse (FCCee/IDEA/compact/IDEA_o1_v01/IDEA_o1_v01.xml:44:2: mismatched tag)
SiD/compact/SiD_o2_v01/Support.xml: Failed to xml parse (SiD/compact/SiD_o2_v01/Support.xml:11:0: junk after document element)
SiD/compact/SiD_o3_v02/Support.xml: Failed to xml parse (SiD/compact/SiD_o3_v02/Support.xml:11:0: junk after document element)
SiD/compact/sidloi3/BeamPipe.xml: Failed to xml parse (SiD/compact/sidloi3/BeamPipe.xml:2:0: junk after document element)
SiD/compact/sidloi3/EcalEndcap.xml: Failed to xml parse (SiD/compact/sidloi3/EcalEndcap.xml:1:153: not well-formed (invalid token))
SiD/compact/SiD_o2_v04/Support.xml: Failed to xml parse (SiD/compact/SiD_o2_v04/Support.xml:11:0: junk after document element)
ILD/compact/ILD_common_v02/all_common_defs.xml: Failed to xml parse (ILD/compact/ILD_common_v02/all_common_defs.xml:3:0: no element found)
ILD/compact/ILD_l4_v01/ILD_l4_v01.xml: Failed to xml parse (ILD/compact/ILD_l4_v01/ILD_l4_v01.xml:7:26: not well-formed (invalid token))
SiD/compact/SiD_o2_v03/Support.xml: Failed to xml parse (SiD/compact/SiD_o2_v03/Support.xml:11:0: junk after document element)
SiD/compact/sidloi3/Support.xml: Failed to xml parse (SiD/compact/sidloi3/Support.xml:11:0: junk after document element)
SiD/compact/SiD_o3_v02/BeamPipe.xml: Failed to xml parse (SiD/compact/SiD_o3_v02/BeamPipe.xml:3:0: junk after document element)
SiD/compact/SiD_o2_v02/Support.xml: Failed to xml parse (SiD/compact/SiD_o2_v02/Support.xml:11:0: junk after document element)
FCCee/CLD/compact/FCCee_o0_v01/FCCee_o0_v01.xml: Failed to xml parse (FCCee/CLD/compact/FCCee_o0_v01/FCCee_o0_v01.xml:11:8: not well-formed (invalid token))
example/sequences.xml: Failed to xml parse (example/sequences.xml:192:14: not well-formed (invalid token))
SiD/compact/SiD_o2_v01/BeamPipe.xml: Failed to xml parse (SiD/compact/SiD_o2_v01/BeamPipe.xml:3:0: junk after document element)
SiD/compact/SiD_o1_v01/HCalEndcap_o1_v03_00.xml: Failed to xml parse (SiD/compact/SiD_o1_v01/HCalEndcap_o1_v03_00.xml:45:67: not well-formed (invalid token))

@tmadlener tmadlener merged commit 1c08a6f into key4hep:master Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants