Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: add shim for LCIO::lcio #320

Merged
merged 2 commits into from
Feb 16, 2024
Merged

CMake: add shim for LCIO::lcio #320

merged 2 commits into from
Feb 16, 2024

Conversation

andresailer
Copy link
Contributor

@andresailer andresailer commented Feb 14, 2024 •
edited
Loading

BEGINRELEASENOTES

  • CMake: Add shim for older LCIO versions that do not have LCIO::lcio yet
  • LinearSortingPolicy: adapt check for existing extension to silence error message from DD4hep

ENDRELEASENOTES

tmadlener
tmadlener reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that the find_package(LCIO) populates all it's dependencies correctly (which I think it does), this looks good to me.

Modulo minimal format nitpick.

CMakeLists.txt Outdated Show resolved Hide resolved
@jmcarcell
Copy link
Member

Let's wait until the DD4hep issue is fixed to see the CI in the nightlies green...

@andresailer
Copy link
Contributor Author

The failing tests are just idea timeouts now

tmadlener
tmadlener approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you found another victim of AIDASoft/DD4hep#1226 ;)

@andresailer
Copy link
Contributor Author

Oh, you found another victim of AIDASoft/DD4hep#1226 ;)

Yeah, the last tests failing here.
At least I managed to find these with grep instead of having to use gdb 😁

@andresailer andresailer merged commit 9889d01 into key4hep:main Feb 16, 2024
9 of 11 checks passed
@andresailer andresailer deleted the lcioFix branch February 16, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

@jmcarcell jmcarcell Awaiting requested review from jmcarcell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresailer @jmcarcell @tmadlener