Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LCIO an optional dependency #328

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Make LCIO an optional dependency #328

merged 3 commits into from
Mar 6, 2024

Conversation

zaborowska
Copy link
Contributor

BEGINRELEASENOTES

  • Make LCIO an optional dependency. If LCIO is not found, some detectors (trackers) will not be built.

ENDRELEASENOTES

The list of the detectors in CMakeLists that depend on LCIO is hard-coded and needs to be modified for each new LCIO-dependent detector.

Copy link
Contributor

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. But is is better to be explicit about the use of LCIO or not to avoid confusion when it is present or not.

PS: I haven't tested the syntax of my proposed changes

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@jmcarcell
Copy link
Member

I have taken the liberty to apply the suggestions and fix the syntax, I'm sure Anna won't mind. With these changes I can build without LCIO, which means I can run native Key4hep algorithms without building any of the LCSoft packages.

@jmcarcell
Copy link
Member

Some tests in CLICPerformance seem to be failing (from the downstream-build workflow), but they aren't related and I guess they are failing anyways:

lcio::IOException: [LCReader::open()] File(s) not found:  testCLIC_o3_v14.slcio  

so I'm going to merge this

@jmcarcell jmcarcell merged commit 1122f7d into key4hep:main Mar 6, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants