Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for pandora PFA #419

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Changes for pandora PFA #419

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9259e7c
add detector type, calodata, muon tagger with phi-theta segmentation …
giovannimarchiori Jan 15, 2025
a9c89b8
move to phi-theta grid for muon tagger and use volume compatible with…
giovannimarchiori Jan 15, 2025
7a4153d
add extent info to ecal endcap turbine class
giovannimarchiori Jan 20, 2025
60a2e95
fix typo
giovannimarchiori Jan 23, 2025
f7294b1
fix bug with endcap building
giovannimarchiori Jan 27, 2025
bc87e12
Merge branch 'key4hep:main' into gmarchio-main-pandora-20250114
giovannimarchiori Jan 27, 2025
922e4ce
introduce separate readouts for muon barrel and endcap
giovannimarchiori Jan 27, 2025
e8b4d82
remove commented code
giovannimarchiori Jan 27, 2025
1cef8c7
fix xml
giovannimarchiori Jan 27, 2025
a8b9b09
use same muon detector for ALLEGRO v03 and v04
giovannimarchiori Jan 28, 2025
689a685
try to add segmentation to simple cylinder
giovannimarchiori Jan 29, 2025
1b4ef34
Merge branch 'key4hep:main' into gmarchio-main-pandora-20250114
giovannimarchiori Jan 30, 2025
55da3a9
improve simple cylinder code
giovannimarchiori Jan 31, 2025
3aa5b60
add possibility of having layers in simple cylinder volume
giovannimarchiori Jan 31, 2025
2651b42
set inner and outer radiation and interaction lenghts otherwise pando…
giovannimarchiori Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions FCCee/ALLEGRO/compact/ALLEGRO_o1_v03/MuonTaggerPhiTheta.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,19 @@
</display>

<readouts>
<readout name="MuonTaggerPhiTheta">
<readout name="MuonTaggerBarrelPhiTheta">
<segmentation type="FCCSWGridPhiTheta_k4geo" phi_bins="704" offset_phi="-pi+(pi/704.)" grid_size_theta="0.010013373" offset_theta="0.10884388"/>
<id>system:4,subsystem:1,layer:5,theta:10,phi:10</id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's better to remove the "subsystem" filed? since it is not needed for barrel readout

</readout>
<readout name="MuonTaggerEndcapPhiTheta">
<segmentation type="FCCSWGridPhiTheta_k4geo" phi_bins="704" offset_phi="-pi+(pi/704.)" grid_size_theta="0.010013373" offset_theta="0.10884388"/>
<id>system:4,subsystem:1,layer:5,theta:10,phi:10</id>
</readout>
</readouts>

<detectors>
<!-- positive side: cryostat -->
<detector id="DetID_Muon_Barrel" name="MuonTaggerBarrel" type="SimpleCylinder_o1_v02" sensitive="true" vis="muon_vis" readout="MuonTaggerPhiTheta">
<detector id="DetID_Muon_Barrel" name="MuonTaggerBarrel" type="SimpleCylinder_o1_v02" sensitive="true" vis="muon_vis" readout="MuonTaggerBarrelPhiTheta">
<!-- added for Pandora -->
<type_flags type="DetType_CALORIMETER + DetType_MUON + DetType_BARREL"/>
<!-- end -->
Expand All @@ -36,7 +40,7 @@
dz="MuonTagger_half_length" z_offset = "0" material="Polystyrene" phi0="0" deltaphi="360*deg" vis="muon_vis"/>
</detector>

<detector id="DetID_Muon_Endcap_1" name="MuonTaggerEndcap_positive" type="SimpleCylinder_o1_v02" sensitive="true" vis="muon_vis" readout="MuonTaggerPhiTheta">
<detector id="DetID_Muon_Endcap_1" name="MuonTaggerEndcap" type="SimpleCylinder_o1_v02" sensitive="true" vis="muon_vis" readout="MuonTaggerEndcapPhiTheta">
<!-- added for Pandora -->
<type_flags type="DetType_CALORIMETER + DetType_MUON + DetType_ENDCAP"/>
<!-- end -->
Expand Down