Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect files of different MDI versions in a config file for each version #424

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Collect files of different MDI versions in a config file for each version #424

merged 1 commit into from
Jan 29, 2025

Conversation

Victor-Schwan
Copy link
Contributor

  • collect the files of the individual MDI versions in a “global” MDI version configuration file in the folder of this version
  • avoid redundant specification of the MDI version number in each file name of each component of the MDI version (single source of truth)

BEGINRELEASENOTES

  • collect the files of the individual MDI versions in a “global” MDI version configuration file in the folder of this version
  • avoid redundant specification of the MDI version number in each file name of each component of the MDI version (single source of truth)

ENDRELEASENOTES

tmadlener
tmadlener approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the checks.

@atolosadelgado
Copy link
Collaborator

is it ready to be merged?

@atolosadelgado atolosadelgado merged commit 211e0de into key4hep:main Jan 29, 2025
6 checks passed
@Victor-Schwan Victor-Schwan deleted the squashed_cmmn_MDI branch January 29, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

@atolosadelgado atolosadelgado atolosadelgado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Victor-Schwan @atolosadelgado @tmadlener