Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated class name #529

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Updated class name #529

merged 1 commit into from
Jan 25, 2024

Conversation

hmlnarik
Copy link
Contributor

Fixes: #528

@hmlnarik hmlnarik linked an issue Jan 24, 2024 that may be closed by this pull request
user-storage-simple fails compilation #528
Closed
@hmlnarik hmlnarik marked this pull request as draft January 24, 2024 13:33
@hmlnarik hmlnarik force-pushed the 528-user-storage-simple-fails-compilation-main branch 3 times, most recently from eeeeeeb to 7a562d1 Compare January 25, 2024 09:21
@hmlnarik
Updated class name
86e2c15 
Fixes: keycloak#528

Signed-off-by: Hynek Mlnarik <[email protected]>
@hmlnarik hmlnarik force-pushed the 528-user-storage-simple-fails-compilation-main branch from 7a562d1 to 86e2c15 Compare January 25, 2024 09:21
@hmlnarik
Copy link
Contributor Author

hmlnarik commented Jan 25, 2024 •
edited
Loading

As seen in https://github.com/keycloak/keycloak-quickstarts/actions/runs/7652378985/job/20852023396?pr=529#step:7:1120, the build is now successful.

[INFO] Keycloak Quickstart: parent ........................ SUCCESS [  0.109 s]
[INFO] Quickstart: Action Token With Authenticator ........ SUCCESS [ 19.867 s]
[INFO] Quickstart: Action Token With Required Action ...... SUCCESS [  0.640 s]
[INFO] Keycloak Quickstart: Event Listener System.out ..... SUCCESS [  0.613 s]
[INFO] Keycloak Quickstart: Event Store In-Mem ............ SUCCESS [  0.438 s]
[INFO] Keycloak Quickstarts: Extend Account Console ....... SUCCESS [  5.691 s]
[INFO] Keycloak Quickstart: user-storage-properties ....... SUCCESS [  0.378 s]
[INFO] Keycloak Quickstart: user-storage-jpa .............. SUCCESS [  1.044 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

@hmlnarik hmlnarik marked this pull request as ready for review January 25, 2024 09:33
ahus1
ahus1 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this compile issue!

@ahus1 ahus1 merged commit 4af949c into keycloak:main Jan 25, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahus1 ahus1 ahus1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user-storage-simple fails compilation
2 participants
@hmlnarik @ahus1