Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common/models): fixes reference dropped by git merge #7313

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

jahorton
Copy link
Contributor

Fixes a post-merge issue caused when merging both of the following two PRs:

From #7205:

image

Note the original line 165:

let contextTokens = contextState.tokens;

This line is referenced by #7241:

image

Due to the way the changes were made, this was not detected as a merge conflict, allowing this to slip through:

image

Fortunately, it's a very easy "conflict" to resolve.

@keymanapp-test-bot skip

@jahorton jahorton added this to the A16S11 milestone Sep 19, 2022
@keymanapp-test-bot
Copy link

User Test Results

Test specification and instructions

User tests are not required

@jahorton jahorton merged commit 316cfd1 into master Sep 19, 2022
@jahorton jahorton deleted the fix/common/models/worker-build-error branch September 19, 2022 02:01
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 16.0.67-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants