feat(web): queued promise prioritizer / resynchronizer 🐵 #9453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
approved these changes
Aug 11, 2023
common/web/gesture-recognizer/src/engine/headless/queuedPromisePrioritizer.ts
Outdated
Show resolved
Hide resolved
common/web/gesture-recognizer/src/engine/headless/queuedPromisePrioritizer.ts
Outdated
Show resolved
Hide resolved
This was referenced Sep 26, 2023
Merged
|
Took a bit of work, but I've been able to successfully remove this PR's changes from its descendants via reversion to the most direct descendant. As noted by #9407 (comment), the component added by this PR is no longer necessary, as a "deeper root" was identified and fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was "fun".
Collects metadata on all near-synchronous calls to its lone public method, intended to handle cases where Promise fulfillment is essentially triggered synchronously. JS has an internal "Promise queue" that ensures consistent ordering with Promise resolution and fulfillment, assuming all Promises of equal priority. Its func exists to customize their order of resolution when fulfilled "synchronously", based on a supplied
priorityvalue - as we will prefer matchers for specific gesture models to always be checked before those of lower priority.The included unit tests should be clear and concise enough to illustrate the intended use of the new class and the sort of problem it's meant to solve.
@keymanapp-test-bot skip