-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): gesture stage sequencing 🐵 #9455
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
jahorton
changed the base branch from
feat/web/gesture-selection
to
feat/web/config-shifting-and-source-rigor
August 30, 2023 03:46
jahorton
force-pushed
the
feat/web/gesture-staging
branch
from
August 30, 2023 03:49
1c45378
to
f6a90e1
Compare
jahorton
force-pushed
the
feat/web/gesture-staging
branch
from
August 30, 2023 05:04
f6a90e1
to
1f36d90
Compare
jahorton
force-pushed
the
feat/web/gesture-staging
branch
from
September 21, 2023 04:46
0c904d3
to
491bba2
Compare
jahorton
changed the base branch from
feat/web/config-shifting-and-source-rigor
to
chore/web/misc-gesture-fixes-and-cleanup
September 21, 2023 04:46
jahorton
force-pushed
the
feat/web/gesture-staging
branch
from
September 26, 2023 01:53
9149693
to
5b6932a
Compare
jahorton
changed the title
feat(web): gesture-staging 🐵
feat(web): gesture stage sequencing 🐵
Sep 26, 2023
…nto feat/web/gesture-staging
…nto feat/web/gesture-staging
mcdurdin
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Base automatically changed from
chore/web/misc-gesture-fixes-and-cleanup
to
feature-gestures
September 29, 2023 08:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AKA coordinating & correlating the sequence of related gesture components over time.
This PR does a few things:
There have been a few shifts to the gesture-model spec format and to the resolution-handling spec format.
These changes have arisen out of observations that occurred at the newly-achieved level of integration.
sustainWhenNested
is designed to facilitate a complication that will arise for longpresses that are triggered during a modipress interaction: if the subkey menu is shown when the modipress ends, we should probably 'sustain' the subkey selection mode instead of immediately returning to the original layer. This would be a 'nested' longpress... hence the flag name.This adds a formal spec for defining the gestures and gesture sets that are to be utilized by the gesture engine - see
GestureModelDefs
.default
is a required "gesture set" entry.The main class corresponding to the new layer is called
GestureSequence
, as it exists to track the individual gesture components (models) comprising the ongoing 'gesture sequence' over time and facilitate event handling based on the sequence's development as new components are recognized.GestureStageReport
type, which makes the critical data available to external modules while minimally exposing things that are only relevant internally.Finally, what's a good PR like this without a lot of nice, new automated tests to help support and maintain it?
@keymanapp-test-bot skip