gateway2: Add readiness and liveness probes to the kube gloo gateway pod #10332
+1,478
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keep pr updated
davidjumani
removed
the
keep pr updated
davidjumani
force-pushed
the
add-readiness-liveness-probe
branch
from
74b3fa3 to
debf04a
Compare
davidjumani
changed the title
|
Visit the preview URL for this PR (updated for commit 31a2e5d): https://gloo-edge--pr10332-add-readiness-livene-dgc4zcrn.web.app (expires Wed, 20 Nov 2024 20:39:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
|
Issues linked to changelog: |
davidjumani
added
keep pr updated
davidjumani
changed the title
nfuden
reviewed
Nov 13, 2024
Comment on lines
+101
to
+111
| {{- else }} | ||
| exec: | ||
| command: | ||
| - wget | ||
| - -O | ||
| - /dev/null | ||
| - 127.0.0.1:19000/server_info | ||
| initialDelaySeconds: 3 | ||
| periodSeconds: 10 | ||
| failureThreshold: 3 | ||
| {{- end }}{{/*if $gg.podTemplate.customLivenessProbe*/}} |
There was a problem hiding this comment.
Suggested change
| {{- else }} | |
| exec: | |
| command: | |
| - wget | |
| - -O | |
| - /dev/null | |
| - 127.0.0.1:19000/server_info | |
| initialDelaySeconds: 3 | |
| periodSeconds: 10 | |
| failureThreshold: 3 | |
| {{- end }}{{/*if $gg.podTemplate.customLivenessProbe*/}} | |
| {{- end }} |
There was a problem hiding this comment.
This provides a default probe if a custom one is not specified
jenshu
reviewed
Nov 13, 2024
| // If specified, the pod's graceful shutdown spec. | ||
| // | ||
| // +kubebuilder:validation:Optional | ||
| GracefulShutdown *GracefulShutdownSpec `json:"gracefulShutdown,omitempty"` |
There was a problem hiding this comment.
Thanks for this! Updated
sam-heilbron
added
the
work in progress
|
@davidjumani are you still working on this or can it be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update allows users to enable and add custom readiness and liveness probes to the Kubernetes Gloo Gateway.
This allows zero downtime when upgrading gloo or when rolling out new pods
API changes
The following helm changes have been made :
kubeGateway.gatewayParameters.glooGateway.podTemplate.terminationGracePeriodSecondsto specify the terminationGracePeriodSeconds.kubeGateway.gatewayParameters.glooGateway.podTemplate.gracefulShutdownto configure the graceful shutdown config for the envoy container.kubeGateway.gatewayParameters.glooGateway.podTemplate.customLivenessProbeto specify a custom liveness probe for the envoy container.kubeGateway.gatewayParameters.glooGateway.podTemplate.livenessProbeEnabledto enable the liveness probe. If the customLivenessProbe is not specified, a default liveness probe is set.kubeGateway.gatewayParameters.glooGateway.podTemplate.customReadinessProbeto specify a custom readiness probe for the envoy container.kubeGateway.gatewayParameters.glooGateway.podTemplate.probesto enable the readiness probe. If the customReadinessProbe is not specified, a default readiness probe is set.The following fields have been added to the GatewayParameters.Kube.PodTemplate field :
Code changes
Updated the deployer to read the new values from the gateway params and generate the appropriate helm values for the gloo gateway pod deployment
CI changes
Added the zero downtime config to all Kubernetes tests to ensure this does not break an existing feature
Docs changes
TODO in a followup with @solo-io/solo-docs
Context
https://github.com/solo-io/solo-projects/issues/7084
Interesting decisions
The helm values were created to mimic the existing values to setup the probes and zero downtime config for edge classic. Ref: https://github.com/solo-io/solo-projects/issues/7084
Testing steps
Added unit tests
Checklist: