-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AI APIs #10493
Open
npolshakova
wants to merge
22
commits into
kgateway-dev:main
Choose a base branch
from
npolshakova:port-ai-apis-to-kgateway
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for AI APIs #10493
npolshakova
wants to merge
22
commits into
kgateway-dev:main
from
npolshakova:port-ai-apis-to-kgateway
+4,088
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EItanya
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this make sense to me. I have some nits about structure, but my big takeaways are:
- What's the decision process between pointer and non-pointer types throughout the API, it's not clear to me.
- Why are we using
iota
for enums in some place, andstring
aliases in others? - The
AIRouteOptions
need more validation akin to the upstream.
31cda6a
to
3510255
Compare
184f600
to
ad175ad
Compare
63f82c9
to
930afa2
Compare
EItanya
reviewed
Feb 17, 2025
f5d16d3
to
37538fd
Compare
andy-fong
suggested changes
Feb 21, 2025
lgadban
reviewed
Feb 24, 2025
3 tasks
andy-fong
reviewed
Feb 25, 2025
install/helm/kgateway/crds/gateway.kgateway.dev_routepolicies.yaml
Outdated
Show resolved
Hide resolved
andy-fong
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for AI APIs: #10494
API changes
Introduces AI APIs in kgateway. This is based on the Gloo AI APIs.
The HTTPRoute selects an Upstream via a backendRef:
Where an Upstream specifies a provider and auth type:
To select a RoutePolicy you can use extensionRef on the AI Upstream route:
The APIs follow the required vs. optional API conventions defined in https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#optional-vs-required:
Optional fields:
Required fields:
Code changes
Plugin and extauth changes will be implemented in a follow up. This PR only introduces the AI APIs.
CI changes
NONE
Docs changes
NONE
Context
Enhancement Proposal: #10495
Testing steps
Manually validated CR validation by install helm chart and applying example configs.
Checklist: