Pass xds host/port to controller #10688
Open
+135
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
…ds-host Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
…ds-host Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
lgadban
reviewed
Feb 25, 2025
pkg/utils/kubeutils/names.go
Outdated
| GlooXdsPortName = "grpc-xds" | ||
| // GetXdsServiceName returns the name of the Kubernetes Service that serves xDS config. | ||
| func GetXdsServiceName() string { | ||
| if name := os.Getenv("XDS_SERVICE_NAME"); name != "" { |
There was a problem hiding this comment.
any reason to not treat these as "settings"? (ref:. #10666 (comment))
not blocking but would prefer to keep things consistent (even if we do end up moving away from envconfig)
There was a problem hiding this comment.
it was just quicker to plumb through this way, and we have an issue filed for later to consolidate the ways we pass config. but mostly, it's because i forgot about your comment til after i already implemented it haha. but i think it's a good idea, let me try using the Settings
…ds-host Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
jenshu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10659
Fixes #10660