This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
Add service node status colors #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. note that we'll have some changes around graph concepts (workloads health will be introduced). |
|
Looks good, I agree with @abonas the new health for workload still follows the same logic and I don't see any reason to use different colors. |
serenamarie125
approved these changes
Jul 31, 2018
There was a problem hiding this comment.
This looks great to me @cshinn. I'll wait til the end of the day for additional input before merging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Service Graph page with information about service node status colors.
Closes #6