Add edge status colors #29
Conversation
|
|
||
| ### Unused | ||
|  | ||
| - Grey Stroke: #8b8d8f (pf-black-500) |
There was a problem hiding this comment.
What is the use case for "unused"?
There was a problem hiding this comment.
In the current legend, that's labeled with "no traffic yet"
There was a problem hiding this comment.
Isn't Idle == no traffic?
If unused means no traffic, what idle means then?
There was a problem hiding this comment.
Edges to an unused node have no traffic (i.e. the dotted lines). They exist only when there are multiple versions and we group it with the other version nodes. Having the same color for
"idle" edges (i.e. an edge that has shown traffic for other time ranges, but not for the current one) and unused edges (has never seen traffic), makes sense.
As for the legend, I think this will be a high priority for Sprint 10, and it should be replaced with a dialog with much more detailed descriptions.
|
is this the resolution for https://github.com/kiali/kiali-design/issues/24? if so, they should be linked (and then #24 will auto close when this one is merged) |
|
@mtho11 fyi |
|
@jshaughn if you are taking https://issues.jboss.org/browse/KIALI-1194 you will need to add this |
Adds recommendations for graph edge status colors
Updates pf-black-400 to pf-black-500 to increase contrast
closes #24