Add metrics chart display recommendations #31
Conversation
| @@ -0,0 +1 @@ | |||
| .DS_Store | |||
There was a problem hiding this comment.
Mac computers create these little metadata files and they get annoying
services/design.md
Outdated
| - Charts should be displayed at a fixed height, but if this is not possible/practical both charts in each pair should have the same height. | ||
|
|
||
|  | ||
| - Alternatively, charts could be grouped into cards by the metric that they represent. In this case, they would exhibit the same behaviors described above. |
There was a problem hiding this comment.
I'm not clear what does "group charts into cards" mean ? having several different metrics in the same graph?
There was a problem hiding this comment.
It's just a different visual presentation of the same information, putting the charts for input and output request volume on a card for instance rather than having everything on a white page.
services/design.md
Outdated
|  | ||
| - Alternatively, charts could be grouped into cards by the metric that they represent. In this case, they would exhibit the same behaviors described above. | ||
|
|
||
|  |
There was a problem hiding this comment.
is this image with visible legend correct? (I mean the legend visible below the graph at all times)
There was a problem hiding this comment.
That should only be when a graph is expanded to fill the whole screen. I'll update to make that clearer
|
@jotak fyi, please review |
|
@cshinn , @abonas I like the idea of grouping in/out charts by pairs in cards. Also, I wonder when they're grouped horizontally like this, we could maybe take the legend back (every chart wouldn't have the same height, but at least they would be aligned). 'Cause I fear removing the bottom legend has too many drawbacks: the bottom legend has the advantage to be interactive, makes it more immediate to understand the chart, also is probably more printing/screenshot-friendly. It's great to be able to filter on histogram stats: it's a step in the direction of enhancing this screen, but we could also do more: see https://issues.jboss.org/browse/KIALI-936 (created a while ago but still valid). It would be nice to be able to filter out from label values (so, this is dynamic filtering as we don't know in advance what those values are). Use Case Example: I want to compare metrics between v5 and v6 of my service. So I ask to show metrics by version, and get v1/v2/v3/v4/v5/v6. I'm only interested in the last two, others is noise. We could be able to remove v1 to 4 from the list of version values. |
|
@jotak I think that's a good point. Having the charts paired could let us use the legend without messing up alignment. We should try that and see if it works well in unusual situations. |
|
@cshinn just making sure I understand this correctly - this is waiting for some updates from your side on the paired charts legend? |
|
@abonas I've updated the recommendations to reflect our discussion |
Adds two options for displaying charts on the service metrics page and some other small changes.
Adds .gitignore file
Closes #12