Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

Add designs for graph controls #45

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Conversation

cshinn
Copy link
Contributor

@cshinn cshinn commented Sep 10, 2018

Adds designs and placement for a number of graph controls

  • Rearranges and relocates the fetching controls
  • Restructures the graph settings and reduces dropdown size
  • Relocates the graph layout selector to the zoom tool

Closes #41
Closes #20
Closes #14

@mwringe
Copy link

mwringe commented Sep 10, 2018

I am not sure if the 'application group' and 'application versioned' is what we want to be doing here. A workload graph and an application graph are two different graph types. As a user I think it would be more clear for me to choose between an application graph or a workload graph, rather than an option to group workloads by application.

Everything else looks great though

@mwringe
Copy link

mwringe commented Sep 10, 2018

@cshinn Should the 'fetching' controls also be the same across the other pages that do refreshes (such as the metric pages)

@jshaughn
Copy link

I love the enhanced zoom tool with the 3 layout options. Let's make this change ASAP.

Overall, I like that the uber-options is being simplified.

I agree with @mwringe about the graph types. As is the graph types are buried, I'd prefer to see it be explicit and easy to change. I'd suggest either a "Graph Type" header (like "Badges") with the three options: Workload, App, Versioned App. Or, perhaps even another button bar at the bottom.

I think we should consider moving "Security" to the "Badges" section and out of the "Edge Labels" dropdown. If selected the lock icon could simply be prepended to any other edge label selection.

Everything else seems fine to me.

@abonas
Copy link
Contributor

abonas commented Dec 4, 2018

@cshinn I see there are some conflicts preventing this from being merged, can you please resolve them?

1 similar comment
@abonas
Copy link
Contributor

abonas commented Dec 25, 2018

@cshinn I see there are some conflicts preventing this from being merged, can you please resolve them?

@serenamarie125
Copy link
Contributor

@cshinn can you resolve the conflicts so I can merge? Thanks!

@cshinn
Copy link
Contributor Author

cshinn commented Jan 2, 2019

I've updated this branch to resolve the merge conflict

@abonas
Copy link
Contributor

abonas commented Jan 3, 2019

@jshaughn please review, is this up to date with the most recent graph toolbar?

Copy link

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the graph page I see in 0.12 meets all of these design goals.

@abonas abonas merged commit 0976ab8 into kiali:master Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants