-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
I am not sure if the 'application group' and 'application versioned' is what we want to be doing here. A workload graph and an application graph are two different graph types. As a user I think it would be more clear for me to choose between an application graph or a workload graph, rather than an option to group workloads by application. Everything else looks great though |
@cshinn Should the 'fetching' controls also be the same across the other pages that do refreshes (such as the metric pages) |
I love the enhanced zoom tool with the 3 layout options. Let's make this change ASAP. Overall, I like that the uber-options is being simplified. I agree with @mwringe about the graph types. As is the graph types are buried, I'd prefer to see it be explicit and easy to change. I'd suggest either a "Graph Type" header (like "Badges") with the three options: Workload, App, Versioned App. Or, perhaps even another button bar at the bottom. I think we should consider moving "Security" to the "Badges" section and out of the "Edge Labels" dropdown. If selected the lock icon could simply be prepended to any other edge label selection. Everything else seems fine to me. |
@cshinn I see there are some conflicts preventing this from being merged, can you please resolve them? |
1 similar comment
@cshinn I see there are some conflicts preventing this from being merged, can you please resolve them? |
@cshinn can you resolve the conflicts so I can merge? Thanks! |
I've updated this branch to resolve the merge conflict |
@jshaughn please review, is this up to date with the most recent graph toolbar? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the graph page I see in 0.12 meets all of these design goals.
Adds designs and placement for a number of graph controls
Closes #41
Closes #20
Closes #14