Add alternative object details designs #65
Conversation
| - Move health into header (details still available on hover) | ||
| - More space for ports and endpoints lists | ||
|
|
||
| ## Big changes big difference |
There was a problem hiding this comment.
this is great as well, I think it should be a different item. As I discussed with @serenamarie125 I'm in favor of this, I'd like to understand better how long does it take to convert pf3 to pf4. Also worth to understand - why pf3 is not getting this style change so all projects can enjoy it "for free"? With the current situation, every project has to do separate work to make it look like this.
There was a problem hiding this comment.
@abonas we need to set up a meeting with the appropriate PatternFly team members. Who are the appropriate people to include on the Service Mesh side?
There was a problem hiding this comment.
@abonas we need to set up a meeting with the appropriate PatternFly team members. Who are the appropriate people to include on the Service Mesh side?
it depends what is the goal of the meeting - can you elaborate?
|
|
||
| ## Sidecar field | ||
|  | ||
| - We could add a `sidecar` field to the item details to illustrate whether the sidecar is missing or represent |
There was a problem hiding this comment.
I think this it the less optimal place to be part of, and at the bottom of the details.
It is also conceptually not "the same" as the other details here, because it is something "applied to" and not really "part of" the current entity.
There was a problem hiding this comment.
I am in favor of either putting the sidecar indicator in line with the header or below the header, but not as part of details section.
| ## Moderate style changes | ||
| Adds more space to the page and brings it in line with other cloud software | ||
|
|
||
|  |
There was a problem hiding this comment.
LOVE that. can you elaborate on the technical aspect? where do we get details about which font/what kind of styling to apply?
There was a problem hiding this comment.
This view is essentially using the exact same styles as OKD uses for its object detail views. I'm not sure how difficult it would be to reuse their stylesheets, but I'm sure we can put together a spec if this is the road we want to go down
|  | ||
| - We could add a `sidecar` field to the item details to illustrate whether the sidecar is missing or represent | ||
|
|
||
| ## Minor page structure improvements |
There was a problem hiding this comment.
@cshinn I will add another story for you to investigate a design utilizing the PF3 React data grid component rather than the list view which is currently being used. I think this would also be helpful, what do you think?
There was a problem hiding this comment.
That sounds good. Is that the component used in OKD right now?
This doc has a few designs for object details pages (service page specifically, but something very similar could be done for workloads, etc).
Each step builds on the previous one, so we can take the changes as far as makes sense at a given time. This PR does not add new content (with the exception of the missing sidecar indicator) but is a rearrangement of existing things on the page
Closes #61