Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more blurbs on spec.version #819

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

Comment on lines 18 to 20
CR. You do, however, need to specify the version to install. Normally, you
can just set this to `default` which tells the Kiali Operator to install
the Kiali Server whose version is the same as that of the operator itself:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CR. You do, however, need to specify the version to install. Normally, you
can just set this to `default` which tells the Kiali Operator to install
the Kiali Server whose version is the same as that of the operator itself:
CR. You do, however, need to specify the version to install. Normally, you
can just set this to `default` which tells the Kiali Operator to install the
Kiali Server whose version is the same as that of the operator itself. But, to
update the Kiali Operator while maintaining a fixed Kiali Server, you must
set the specific Kiali Server version.

You can re-word it, or maybe show the version format, but I think it would be good to be a little more elaborate here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-worded

Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better.

@jmazzitelli jmazzitelli changed the title spec.version is required more blurbs on spec.version Sep 27, 2024
@jmazzitelli jmazzitelli merged commit 998e67d into kiali:staging Sep 27, 2024
5 checks passed
@jmazzitelli jmazzitelli deleted the spec.version branch September 27, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants