Replace assertValues with single value to assertLastValue in pledge view model tests #2270
+110
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
requested review from
scottkicks,
ifosli and
stevestreza-ksr
5 tasks
scottkicks
approved these changes
Feb 3, 2025
jovaniks
approved these changes
Feb 3, 2025
amy-at-kickstarter
deleted the
feat/adyer/slightly-simplify-pledge-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Replace calls to
assertValues([true])toassertLastValue(true)andassertValues([false])toassertLastValue(false).🤔 Why
These tests frequently operate as change detectors - they break under small, trivial refactors. To whit, much of my attempts to refactor checkout code have caused harmless signal side effects which break the tests.
For example, if a signal emits
[true, true]instead of[true], is it actually a bug? The UI would have no notion of that change, nor would the user. And while I wish I could make all of my refactoring purely side-effect free, it hasn't been realistic, unfortunately.Fixing this will make it easier to refactor our checkout code, without breaking tests, and adding minimal risk.
🛠 How
Find-n-replace.