Bump h2 from 1.4.197 to 2.2.220

[tkobayas]

• remove MVCC

referenced Pull Requests:

• Bump h2 from 1.4.197 to 2.2.220 droolsjbpm-build-bootstrap#2356
• https://github.com/kiegroup/drools/pull/5395
• Bump h2 from 1.4.197 to 2.2.220 droolsjbpm-integration#2983
• Bump h2 from 1.4.197 to 2.2.220 jbpm-work-items#285
• Bump h2 from 1.4.197 to 2.2.220 kie-jpmml-integration#83

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

• a pull request please add comment: Jenkins retest this

• a full downstream build please add comment: Jenkins run fdb

• a compile downstream build please add comment: Jenkins run cdb

• a full production downstream build please add comment: Jenkins execute product fdb

• an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

[tkobayas]

Removing ;MVCC=true and adding ;MODE=LEGACY;OLD_INFORMATION_SCHEMA=TRUE is not enough.

[2023-07-20T03:28:27.827Z] 2023-07-19 23:28:26,670 [main] [SqlExceptionHelper] ERROR Table "CORRELATIONPROPERTYINFO" not found; SQL statement:

Even table creation seems to be failing.

It is out of my expertise. @gmunozfe Could you kindly help on this or involve someone suitable? Thanks!

[tkobayas]

A great number of test failures are resolved. Now 7 failures. Thank you and please check them! @gmunozfe

Test Result (7 failures / +7)
    org.jbpm.test.container.test.ejbservices.process.EMigrateProcessTest.testUpgradeProcessInstancesWithNodeMapping
    org.jbpm.test.container.test.ejbservices.process.EMigrateProcessTest.testUpgradeProcessInstance
    org.jbpm.test.container.test.ejbservices.process.EMigrateProcessTest.testUpgradeProcessInstances
    org.jbpm.test.container.test.ejbservices.process.EMigrateProcessTest.testUpgradeProcessInstanceWithNodeMapping
    org.jbpm.test.container.test.ejbservices.task.EGetTaskTest.testGetTaskInstanceInfo
    org.jbpm.test.container.test.ejbservices.task.EGetTaskTest.testTaskQuery
    org.jbpm.test.container.test.ejbservices.task.ETaskOperationTest.testStartAndComplete

[tkobayas]

0 failed. Thanks! @gmunozfe

Now I re-triggered

• PR test in Bump h2 from 1.4.197 to 2.2.220 droolsjbpm-integration#2983
• FDB in Bump h2 from 1.4.197 to 2.2.220 droolsjbpm-build-bootstrap#2356

[gmunozfe]

@tkobayas Great, however, I'm not very convinced with my last commit (it's a workaround valid for h2 to skip the hibernate bug tracked as HHH-13711, but won't work for the rest of the databases). The point here is these container tests are using wildfly-dist 23.0.0-Final, which doesn't include the hibernate-core fix (from 5.4.13), so dropping tables for cleaning up will only work if we replace that module (it's using hibernate-core-5.3.20.Final) or apply the workaround, wdyt?

[gmunozfe]

@tkobayas Great, however, I'm not very convinced with my last commit (it's a workaround valid for h2 to skip the hibernate bug tracked as HHH-13711, but won't work for the rest of the databases). The point here is these container tests are using wildfly-dist 23.0.0-Final, which doesn't include the hibernate-core fix (from 5.4.13), so dropping tables for cleaning up will only work if we replace that module (it's using hibernate-core-5.3.20.Final) or apply the workaround, wdyt?

@tkobayas Finally, I have decided that parameterization will work fine for other profiles, we can override "metadata" as drop-source and empty for drop-script. Please merge tkobayas#3

[tkobayas]

@gmunozfe Thanks, it looks good.

[tkobayas]

GHA Java11 : Not related to this PR

2023-07-25T06:20:50.2312963Z [ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.23 s <<< FAILURE! - in org.jbpm.process.workitem.email.SendHtmlTest
2023-07-25T06:20:50.2313761Z [ERROR] sendHtmlWithBadAuthentication(org.jbpm.process.workitem.email.SendHtmlTest)  Time elapsed: 0.006 s  <<< ERROR!
2023-07-25T06:20:50.2314444Z java.lang.RuntimeException: java.net.BindException: Address already in use (Bind failed)

[gmunozfe]

Looks good to me, thanks a lot @tkobayas for taking care of this!

[danielezonca]

Overall LGTM, some minor comments, feel free to address them with a following PR if you prefer

[gmunozfe]

@danielezonca @tkobayas I've proposed tkobayas#4 covering all the changes coming from the review

[tkobayas]

@gmunozfe Thank you!

[tkobayas]

The changes are only test cases and jbpm-xes which doesn't have downstream projects, so no need to run FDB in droolsjbpm-build-bootstrap again.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

71.4% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[tkobayas]

0 failed :)