Implement label_errors on OD tasks #100
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gheorghetutunaru
force-pushed
the
feat/test-od-label-errors
branch
14 times, most recently
from
e3221a5 to
c8de677
Compare
gheorghetutunaru
force-pushed
the
feat/test-od-label-errors
branch
3 times, most recently
from
0526bd5 to
053fa5a
Compare
gheorghetutunaru
force-pushed
the
feat/test-od-label-errors
branch
from
053fa5a to
058f3f0
Compare
PierreLeveau
reviewed
Jul 1, 2022
| @@ -8,3 +8,4 @@ kiliautoml/utils/ultralytics/yolov5/artifacts | |||
| wandb/** | |||
| .mypy_cache/** | |||
| kiliautoml.egg-info/** | |||
| error_labels.json | |||
There was a problem hiding this comment.
this should land in the code repository by default, so you can rm it.
| clear_dataset_cache | ||
| and os.path.exists(data_path) | ||
| and os.path.isdir(data_path) | ||
| and (not label_error_n_folds or (label_error_n_folds and label_error_cv_fold == 0)) |
There was a problem hiding this comment.
not label_error_n_folds or (label_error_n_folds and label_error_cv_fold == 0) should be put into a variable with an explicit name.
| from typing import Dict, List | ||
|
|
||
| from typing_extensions import Literal, TypedDict | ||
|
|
||
| HOME = os.path.join(os.getenv("HOME"), ".cache", "kili", "automl") # type: ignore | ||
|
|
||
| AUTOML_REPO_ROOT = Path(__file__).resolve().parents[2] |
There was a problem hiding this comment.
I am not sure that this will work if automl is installed as a package and used from another directory.
There was a problem hiding this comment.
but anyway no big deal since we should get rid of Yolo as submodule moving forward
|
|
||
| # Predict by batch of images | ||
| pbar = tqdm(dataloader, bar_format="{l_bar}{bar:10}{r_bar}{bar:-10b}") # progress bar | ||
| for _, (imgs_batche, targets, paths, shapes) in enumerate(pbar): |
| @@ -11,13 +11,14 @@ exclude = ''' | |||
|
|
|||
| [tool.pylint.master] | |||
| suggestion-mode = true | |||
| ignore-paths = [ "^kiliautoml/utils/ultralytics/yolov5/.*$"] | |||
| ignore-paths = [ "^kiliautoml/utils/ultralytics/yolov5/.*$", "kiliautoml/utils/label_errors/yolo_general.py", "kiliautoml/utils/label_errors/yolo_metrics.py"] | |||
There was a problem hiding this comment.
ignored because this is code we copied from yolo ?
|
|
||
| import numpy as np | ||
|
|
||
| from commands.prioritize import Prioritizer, PriorityQueue | ||
|
|
||
| print(sys.path) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.