fix: no openid scope crash

kinde-oss · Mar 2, 2024 · bc78dab · bc78dab
1 parent a15b184
commit bc78dab
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/lib/__tests__/sdk/utilities/token-utils.spec.ts b/lib/__tests__/sdk/utilities/token-utils.spec.ts
@@ -32,6 +32,23 @@ describe('token-utils', () => {
       );
       expect(await sessionManager.getSessionItem('id_token')).toBe(mockIdToken);
     });
+
+    it('stores all provided tokens to memory no id_token', async () => {
+      const { token: mockAccessToken } = mocks.getMockAccessToken({domain});
+      const tokenCollection: TokenCollection = {
+        refresh_token: 'refresh_token',
+        access_token: mockAccessToken,
+      };
+      await commitTokensToMemory(sessionManager, tokenCollection);
+
+      expect(await sessionManager.getSessionItem('refresh_token')).toBe(
+        tokenCollection.refresh_token
+      );
+      expect(await sessionManager.getSessionItem('access_token')).toBe(
+        mockAccessToken
+      );
+      expect(await sessionManager.getSessionItem('id_token')).toBe(null);
+    });
   });
 
   describe('commitTokenToMemory()', () => {

diff --git a/lib/sdk/utilities/token-utils.ts b/lib/sdk/utilities/token-utils.ts
@@ -37,6 +37,10 @@ export const commitTokenToMemory = async (
   token: string,
   type: TokenType
 ): Promise<void> => {
+  if (!token) {
+    await sessionManager.removeSessionItem(type);
+    return;
+  }
   if (type !== 'refresh_token' && isTokenExpired(token)) {
     throw new KindeSDKError(
       KindeSDKErrorCode.INVALID_TOKEN_MEMORY_COMMIT,

diff --git a/lib/sdk/utilities/types.ts b/lib/sdk/utilities/types.ts
@@ -1,7 +1,7 @@
 export interface TokenCollection {
   refresh_token: string;
   access_token: string;
-  id_token: string;
+  id_token?: string;
 }
 
 export interface UserType {