marshalling other config as well for backwards compatibility

kinde-oss · Nov 15, 2024 · ffeaa4f · ffeaa4f
1 parent 1696ece
commit ffeaa4f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/workflowBundler/workflowBundler.go b/workflowBundler/workflowBundler.go
@@ -17,8 +17,8 @@ type (
 	bundlerContext string
 
 	WorkflowSettings[TSettings any] struct {
-		Bindings   map[string]runtimesRegistry.BindingSettings `json:"bindings"`
-		Additional TSettings
+		Bindings map[string]runtimesRegistry.BindingSettings `json:"bindings"`
+		Other    TSettings                                   `json:"other"`
 	}
 
 	BundledContent[TSettings any] struct {
@@ -188,7 +188,7 @@ func (settings *WorkflowSettings[TSettings]) UnmarshalJSON(data []byte) error {
 	set := new(TSettings)
 	err = json.Unmarshal(data, set)
 
-	settings.Additional = *set
+	settings.Other = *set
 
 	return err
 

diff --git a/workflowBundler/workflowBundler_test.go b/workflowBundler/workflowBundler_test.go
@@ -41,7 +41,7 @@ func Test_WorkflowBundler(t *testing.T) {
 	assert.True(pluginSetupWasCalled, "plugin setup was not called")
 	assert.Equal(bundlerResult.Errors[0], "ID is required")
 	assert.NotEmpty(bundlerResult.Content.Source)
-	assert.Equal("tokenGen", bundlerResult.Content.Settings.Additional.ID)
-	assert.Equal("onTokenGeneration", bundlerResult.Content.Settings.Additional.Trigger)
+	assert.Equal("tokenGen", bundlerResult.Content.Settings.Other.ID)
+	assert.Equal("onTokenGeneration", bundlerResult.Content.Settings.Other.Trigger)
 	assert.NotEmpty(bundlerResult.Content.BundleHash)
 }