Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image carousel revive #763

Open
wants to merge 9 commits into
base: staging
Choose a base branch
from
Open

Image carousel revive #763

wants to merge 9 commits into from

Conversation

berenteb
Copy link
Contributor

No description provided.

@berenteb berenteb requested review from Gerviba and Isti01 August 25, 2024 17:21
Copy link

vercel bot commented Aug 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmsch-g7 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 3:08pm
cmsch-golyabal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 3:08pm
cmsch-gtb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 3:08pm
cmsch-qpa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 3:08pm
cmsch-testing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 3:08pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cmsch-cst ⬜️ Ignored (Inspect) Sep 7, 2024 3:08pm
cmsch-felezo ⬜️ Ignored (Inspect) Sep 7, 2024 3:08pm
cmsch-golyakonf ⬜️ Ignored (Inspect) Sep 7, 2024 3:08pm
cmsch-golyakorte ⬜️ Ignored (Inspect) Sep 7, 2024 3:08pm
cmsch-karacsony ⬜️ Ignored (Inspect) Sep 7, 2024 3:08pm
cmsch-kozelokepzes ⬜️ Ignored (Inspect) Sep 7, 2024 3:08pm
cmsch-schnyari ⬜️ Ignored (Inspect) Sep 7, 2024 3:08pm
cmsch-seniortabor ⬜️ Ignored (Inspect) Sep 7, 2024 3:08pm
cmsch-snyt ⬜️ Ignored (Inspect) Sep 7, 2024 3:08pm
cmsch-tanfolyam ⬜️ Ignored (Inspect) Sep 7, 2024 3:08pm

@@ -108,6 +108,7 @@ export interface Home {
youtubeVideoId: string
showEvents: boolean
showNews: boolean
images: string[]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no such field in HomeComponent, but there is an api endpoint for retrieving images from gallery: /api/gallery

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I created an endpoint for it here
#764

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged it, you can rebase to use it

@Isti01 Isti01 force-pushed the staging branch 2 times, most recently from da4d5a8 to 3b8e57c Compare September 1, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants